Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/middleware-recursion-detection/src/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,27 @@ describe(recursionDetectionMiddleware.name, () => {
expect(request.headers[TRACE_ID_HEADER_NAME]).toBe("some-real-trace-id");
});

it(`should NOT set ${TRACE_ID_HEADER_NAME} header when the header is already set in all lowercase`, async () => {
process.env = {
AWS_LAMBDA_FUNCTION_NAME: "some-function",
_X_AMZN_TRACE_ID: "some-trace-id",
};
const handler = recursionDetectionMiddleware({ runtime: "node" })(mockNextHandler, {} as any);
await handler({
input: {},
request: new HttpRequest({
headers: {
[TRACE_ID_HEADER_NAME.toLowerCase()]: "some-real-trace-id",
},
}),
});

const { calls } = (mockNextHandler as any).mock;
expect(calls.length).toBe(1);
const { request } = mockNextHandler.mock.calls[0][0];
expect(request.headers[TRACE_ID_HEADER_NAME.toLowerCase()]).toBe("some-real-trace-id");
});

it("has no effect for browser runtime", async () => {
process.env = {
AWS_LAMBDA_FUNCTION_NAME: "some-function",
Expand Down
4 changes: 3 additions & 1 deletion packages/middleware-recursion-detection/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export const recursionDetectionMiddleware =
if (
!HttpRequest.isInstance(request) ||
options.runtime !== "node" ||
request.headers.hasOwnProperty(TRACE_ID_HEADER_NAME)
Object.keys(request.headers).some(
(key) => key.toLowerCase() === TRACE_ID_HEADER_NAME.toLowerCase()
)
) {
return next(args);
}
Expand Down
Loading