Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 18, 2025

Issue

Internal JS-5849

Description

Updates smithy CLI to 1.56.0

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr

This comment was marked as off-topic.

@trivikr
Copy link
Member Author

trivikr commented Apr 18, 2025

The HttpEmptyPrefixHeadersRequestClient protocol test is failing

 FAIL  test/functional/restxml.spec.ts > HttpEmptyPrefixHeadersRequestClient:Request
AssertionError: expected 'Hello' to be 'There' // Object.is equality

Expected: "There"
Received: "Hello"

 ❯ test/functional/restxml.spec.ts:1451:32
    1449| 
    1450|     expect(r.headers["hello"]).toBeDefined();
    1451|     expect(r.headers["hello"]).toBe("There");
       |                                ^
    1452|     expect(r.headers["x-foo"]).toBeDefined();
    1453|     expect(r.headers["x-foo"]).toBe("Foo");

@trivikr
Copy link
Member Author

trivikr commented May 1, 2025

Superseded by #7045

@trivikr trivikr closed this May 1, 2025
@trivikr trivikr deleted the smithy-1.56.0 branch May 8, 2025 15:17
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant