Skip to content

fix(tests): Fix destructuring error by removing silent catch block #7081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

fix(tests): Fix destructuring error by removing silent catch block #7081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions tests/e2e/ensure-test-stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,12 @@ exports.ensureTestStack = async (client, stackName, templateBody) => {
// TODO: Feature Request: return the last describe response from the waiter result, so we can inspect failure reasons.
await waitUntilChangeSetCreateComplete({ client, maxWaitTime: 300 }, { ChangeSetName: Id });
} catch (e) {
const { Status, StatusReason = "" } = await client
.send(
new DescribeChangeSetCommand({
StackName: stackName,
ChangeSetName: Id,
})
)
.catch((e) => console.warn("Failed to describe changeset", e));
const { Status, StatusReason = "" } = await client.send(
new DescribeChangeSetCommand({
StackName: stackName,
ChangeSetName: Id,
})
);
if (Status === "FAILED" && StatusReason.includes("The submitted information didn't contain changes")) {
await client
.send(
Expand Down
Loading