chore(codegen): use block for token provider call #7099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
approved these changes
May 23, 2025
kuhe
reviewed
May 23, 2025
| .addImport("FromSsoInit", null, AwsDependency.TOKEN_PROVIDERS) | ||
| .write("async (idProps) => await nodeProvider(idProps as FromSsoInit)(idProps)")) | ||
| .openBlock("async (idProps) => {", "}", () -> { | ||
| w.write("return await nodeProvider(idProps as FromSsoInit)(idProps);"); |
There was a problem hiding this comment.
async function can return without await
There was a problem hiding this comment.
It can, but we want errors to be thrown inside the function block, for changes coming up in future.
Not specifically for this line, but when we'll add a try block in future.
If it returns without await the error will be thrown where it's awaited by callee.
kuhe
approved these changes
May 23, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Avoid conflicts with JS-5860
Description
Uses block for token provider call
Testing
N/A, as it's formatting change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.