Skip to content

chore(core/protocols): fix for XML shape deser #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

chore(core/protocols): fix for XML shape deser #7160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d09079e
chore(core/protocols): fix for XML shape deser
kuhe Jun 27, 2025
b764a9c
chore: unused import
kuhe Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions packages/core/src/submodules/protocols/xml/XmlShapeDeserializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { FromStringShapeDeserializer } from "@smithy/core/protocols";
import { NormalizedSchema } from "@smithy/core/schema";
import { getValueFromTextNode } from "@smithy/smithy-client";
import { Schema, SerdeFunctions, ShapeDeserializer } from "@smithy/types";
import type { Schema, SerdeFunctions, ShapeDeserializer } from "@smithy/types";
import { toUtf8 } from "@smithy/util-utf8";
import { XMLParser } from "fast-xml-parser";

import { SerdeContextConfig } from "../ConfigurableSerdeContext";
import { XmlSettings } from "./XmlCodec";
import type { XmlSettings } from "./XmlCodec";

/**
* @alpha
Expand Down Expand Up @@ -59,11 +59,10 @@ export class XmlShapeDeserializer extends SerdeContextConfig implements ShapeDes
public readSchema(_schema: Schema, value: any): any {
const ns = NormalizedSchema.of(_schema);
const traits = ns.getMergedTraits();
const schema = ns.getSchema();

if (ns.isListSchema() && !Array.isArray(value)) {
// single item in what should have been a list.
return this.readSchema(schema, [value]);
return this.readSchema(ns, [value]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the change: pass NormalizedSchema instead of a raw schema object to the recursive call.

Passing a raw Schema loses the member context.

}

if (value == null) {
Expand Down Expand Up @@ -132,17 +131,17 @@ export class XmlShapeDeserializer extends SerdeContextConfig implements ShapeDes
}

throw new Error(`@aws-sdk/core/protocols - xml deserializer unhandled schema type for ${ns.getName(true)}`);
} else {
// non-object aggregate type.
if (ns.isListSchema()) {
return [];
} else if (ns.isMapSchema() || ns.isStructSchema()) {
return {} as any;
}

// simple
return this.stringDeserializer.read(ns, value as string);
}
// non-object aggregate type.
if (ns.isListSchema()) {
return [];
}
if (ns.isMapSchema() || ns.isStructSchema()) {
return {} as any;
}

// simple
return this.stringDeserializer.read(ns, value as string);
}

protected parseXml(xml: string): any {
Expand Down
Loading