fix(codegen): generate default endpoint provider for default regional AWS endpoints #7190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
smithy-lang/smithy-typescript#1643
must be merged and codegen updated before merging this PR.edit: The above PR is related but not required
Description
When a client uses the default regional AWS endpoint ruleset from our code generator, it should now also receive a config resolver that adds a default provider function for
client.config.endpoint()
.This is because pre-endpoints-2.0 it was guaranteed that
config.endpoint()
would exist as a function. This was removed for public AWS SDK clients because we have no way of guaranteeing an endpoint is known without knowing the operation being called, but for internal generated clients this should be retained when using the default regional AWS endpoints, because they are a direct replacement for endpoints.json-based endpoints.Testing
additionally, protocol test clients qualify as non-public AWS clients, and behave in the same way as described above.