test(bundlers): add e2e test for bundler tree-shaking #7245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
PR adds a test to the e2e group, though it does not call AWS.
The test generates two browser bundles of S3 with a single Command using both vite (rollup at the moment) and webpack. The test asserts that the bundle contents are properly tree-shaken, used the correct browser file-replacements, and are not excessively large.
Testing
running the test in the PR
Additional context
sometimes subtle changes can cause treeshaking bailout, especially by webpack.
We have a size benchmark module, but it is non-blocking and hasn't updated many of its packages: https://github.com/aws/aws-sdk-js-v3/blob/main/benchmark/size/report.md
Checklist
*.integ.spec.ts
).@public
tag and enable doc generation on the package?