Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 6, 2025

Issue

n/a

Description

PR adds a test to the e2e group, though it does not call AWS.
The test generates two browser bundles of S3 with a single Command using both vite (rollup at the moment) and webpack. The test asserts that the bundle contents are properly tree-shaken, used the correct browser file-replacements, and are not excessively large.

Testing

running the test in the PR

Additional context

sometimes subtle changes can cause treeshaking bailout, especially by webpack.

We have a size benchmark module, but it is non-blocking and hasn't updated many of its packages: https://github.com/aws/aws-sdk-js-v3/blob/main/benchmark/size/report.md

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner August 6, 2025 16:35
@kuhe kuhe merged commit 7312c1b into aws:main Aug 6, 2025
4 checks passed
@kuhe kuhe deleted the test/bundlers branch August 6, 2025 19:49
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants