test(middleware-flexible-checksums): retry reuses the computed checksum

[trivikr]

Issue

• Internal JS-5905
• Repeat of test(middleware-flexible-checksums): retry reuses the computed checksum #7256 after vitest upgrade to 3.x

Description

Adds an integration test which confirms checksum is not recomputed on retries

Testing

• CI
• ToDo: Dry run is successful

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[trivikr]

Integration test still fails in dry run

 FAIL  packages/middleware-flexible-checksums/src/middleware-flexible-checksums.retry.integ.spec.ts > middleware-flexible-checksums.retry > retry reuses the checksum
AssertionError: expected +0 to deeply equal 1

- Expected
+ Received

- 1
+ 0

 ❯ packages/middleware-flexible-checksums/src/middleware-flexible-checksums.retry.integ.spec.ts:57:29
     55| 
     56|     // Validate that flexibleChecksumsMiddleware is called once.
     57|     expect(flexChecksCalls).toEqual(1);
       |                             ^
     58|     // Validate that retryMiddleware is called maxAttempts times.
     59|     expect(retryMiddlewareCalls).toEqual(maxAttempts);

[trivikr]

After putting a bunch of debug statements, it appears like middleware are added in the stack in dry run, but they're not called

Logs show stack on resolve with anonymous middleware after the ones we want to count

[
  'loggerMiddleware - initialize',
  'validateBucketNameMiddleware - initialize',
  'regionRedirectMiddleware - initialize',
  'ssecMiddleware - initialize',
  'httpAuthSchemeMiddleware - serialize',
  'regionRedirectEndpointMiddleware - before endpointV2Middleware',
  'endpointV2Middleware - serialize',
  'bucketEndpointMiddleware - after endpointV2Middleware',
  'flexibleChecksumsInputMiddleware - before serializerMiddleware',
  'serializerMiddleware - serialize',
  'contentLengthMiddleware - build',
  'addExpectContinueMiddleware - build',
  's3ExpressMiddleware - build',
  'flexibleChecksumsMiddleware - build',
  'anonymous - after flexibleChecksumsMiddleware',
  'getUserAgentMiddleware - build',
  'hostHeaderMiddleware - build',
  'recursionDetectionMiddleware - build',
  'retryMiddleware - finalizeRequest',
  'anonymous - after retryMiddleware',
  'httpSigningMiddleware (a.k.a. apiKeyMiddleware,tokenMiddleware,awsAuthMiddleware) - finalizeRequest',
  'getCheckContentLengthHeaderPlugin - finalizeRequest',
  'deserializerMiddleware - deserialize',
  'throw200ExceptionsMiddleware - after deserializerMiddleware',
  'flexibleChecksumsResponseMiddleware - after deserializerMiddleware'
]

And the log shows that error is thrown after three attempts

{
  err: 500: UnknownError
      at throwDefaultError (/codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/smithy-client/dist-cjs/index.js:388:20)
      at /codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/smithy-client/dist-cjs/index.js:397:5
      at de_CommandError (/codebuild/output/src1124572601/src/aws-sdk-js-v3/packages/nested-clients/dist-cjs/submodules/sts/index.js:299:14)
      at /codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/middleware-serde/dist-cjs/index.js:36:20
      at /codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/core/dist-cjs/index.js:193:18
      at /codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/middleware-retry/dist-cjs/index.js:320:38
      at /codebuild/output/src1124572601/src/aws-sdk-js-v3/packages/middleware-logger/dist-cjs/index.js:33:22
      at Object.roleAssumer (/codebuild/output/src1124572601/src/aws-sdk-js-v3/packages/nested-clients/dist-cjs/submodules/sts/index.js:839:78)
      at /codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/property-provider/dist-cjs/index.js:99:27
      at coalesceProvider (/codebuild/output/src1124572601/src/aws-sdk-js-v3/node_modules/@smithy/property-provider/dist-cjs/index.js:126:18) {
    '$fault': 'client',
    '$metadata': {
      httpStatusCode: 500,
      requestId: undefined,
      extendedRequestId: undefined,
      cfId: undefined,
      attempts: 3,
      totalRetryDelay: 124
    }
  }
}

But it doesn't print the logging statements:

• after flexChecks
• after retryMiddleware

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.