Skip to content

Conversation

smilkuri
Copy link
Contributor

@smilkuri smilkuri commented Sep 5, 2025

Issue

#7311

Description

The Upload class uses PutObject, CreateMultipartUpload, UploadPart, and CompleteMultipartUpload operations internally, so the type should accept parameters for all of these commands.

Testing

Locally

 RUN  v3.2.4 /local/home/smilkuri/aws-sdk-js-v3/lib/lib-storage

 ✓ src/chunks/getChunkUint8Array.spec.ts (6 tests) 7ms
 ✓ src/chunks/getDataReadableStream.spec.ts (4 tests) 161ms
 ✓ src/chunks/getDataReadable.spec.ts (3 tests) 161ms
 ✓ src/index.spec.ts (1 test) 2ms
 ✓ src/Upload.spec.ts (29 tests) 23777ms
   ✓ Upload > should add tags to the object if tags have been added multi-part  23724ms

 Test Files  5 passed (5)
      Tests  43 passed (43)
   Start at  14:04:05
   Duration  24.74s (transform 655ms, setup 0ms, collect 2.25s, tests 24.11s, environment 1ms, prepare 603ms)

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@smilkuri smilkuri requested a review from a team as a code owner September 5, 2025 14:09
@smilkuri smilkuri merged commit 1f7ccf0 into main Sep 5, 2025
7 of 8 checks passed
@smilkuri smilkuri deleted the fix/types branch September 5, 2025 14:55
@nathanthorpe
Copy link

Thank you

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants