Skip to content

Conversation

smilkuri
Copy link
Contributor

@smilkuri smilkuri commented Sep 8, 2025

Issue

Amazon S3 Select closed new customer access on July 25, 2024, as announced in the AWS blog post. While existing customers can continue using the service, new AWS accounts cannot access S3 Select functionality.

The existing E2E test for selectObjectContent was failing in local development environment when using new AWS accounts, thus interrupting the local testing workflow.

Description

This PR adds an integration test for the S3 selectObjectContent operation. The test verifies that the request is correctly formed and sent to the expected endpoint with the proper headers and XML body.

Testing

yarn test:integration

 RUN  v3.2.4 /local/home/smilkuri/aws-sdk-js-v3/clients/client-s3

 ✓ test/integ/s3-selectObjectContent.integ.spec.ts (1 test) 25ms
 ✓ test/integ/s3-object-lambda.integ.spec.ts (1 test) 27ms
 ✓ test/integ/authSchemePreference.integ.spec.ts (6 tests) 44ms

 Test Files  3 passed (3)
      Tests  8 passed (8)
   Start at  21:31:54
   Duration  796ms (transform 325ms, setup 0ms, collect 1.32s, tests 97ms, environment 1ms, prepare 342ms)

Additional context

Add any other context about the PR here.

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cghirardi cghirardi assigned cghirardi and unassigned cghirardi Sep 9, 2025
@smilkuri smilkuri marked this pull request as ready for review September 11, 2025 19:34
@smilkuri smilkuri requested a review from a team as a code owner September 11, 2025 19:34
@smilkuri smilkuri merged commit c65c203 into main Sep 17, 2025
6 checks passed
@smilkuri smilkuri changed the title test(client-s3): add integration test for selectObjectContent test(client-s3): convert selectObjectContent e2e test into integration test Sep 17, 2025
@smilkuri smilkuri deleted the s3Select-integ-test branch September 17, 2025 20:13
Copy link

github-actions bot commented Oct 2, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants