Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 15, 2025

Issue

#3979

Description

Uses window.DOMParser in browsers instead of fast-xml-parser

Testing

new unit tests, also ran all of our existing S3 tests with the browser bundle, confirming that it is using the replacement.

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
    • XML parsing is only used on the response, at which point unit tests do the same job
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner September 15, 2025 19:17
@kuhe
Copy link
Contributor Author

kuhe commented Sep 15, 2025

moved to aws origin

@kuhe kuhe closed this Sep 15, 2025
@kuhe kuhe deleted the feat/xml branch September 15, 2025 19:22
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant