chore(packages): set sideEffects metadata #7358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sets bundler sideEffects metadata explicitly on our packages. The packages for which it is
true
are:util-endpoints
: adds additional functions to the endpoint lib objectcrc64-nvme-crt
: adds an impl to a dependency containersignature-v4-crt
: adds an impl to a dependency containercrt-loader
: flips a flag on a dependency containersignature-v4a
: because it aliases@smithy/signature-v4a
and is meant to be imported as a statement.There's no significant effect on our bundler size benchmarks.
Testing
let CI run
Checklist
*.integ.spec.ts
).@public
tag and enable doc generation on the package?