Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 18, 2025

Description

sets bundler sideEffects metadata explicitly on our packages. The packages for which it is true are:

util-endpoints: adds additional functions to the endpoint lib object
crc64-nvme-crt: adds an impl to a dependency container
signature-v4-crt: adds an impl to a dependency container
crt-loader: flips a flag on a dependency container
signature-v4a: because it aliases @smithy/signature-v4a and is meant to be imported as a statement.

// e.g.
import "@aws-sdk/signature-4a";

There's no significant effect on our bundler size benchmarks.

Testing

let CI run

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts).
  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner September 18, 2025 16:59
@kuhe kuhe force-pushed the chore/sideEffects branch from 1f4f8f8 to d560d39 Compare September 18, 2025 17:04
@kuhe kuhe merged commit c1611a0 into main Sep 18, 2025
7 checks passed
@kuhe kuhe deleted the chore/sideEffects branch September 18, 2025 19:06
Copy link

github-actions bot commented Oct 3, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants