Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 24, 2025

Issue

smithy-lang/smithy-typescript#1600
preparatory compatibility fixes for Schemas

Description

Fixes for unreleased features.

  • fix for applying the LazyJsonString adapter in cases where the input is a JSON object rather than a string
  • change test assertions to ignore ordering of query parameters
  • return early for unit schema in XML shape deserializer
  • fix to fully populate error fields in AwsQuery protocol
  • defer content length determination to the contentLengthMiddleware rather than protocol methods

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts).
  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner September 24, 2025 14:55
@kuhe kuhe marked this pull request as draft September 24, 2025 15:34
@kuhe kuhe marked this pull request as ready for review September 24, 2025 15:34
@kuhe kuhe merged commit 5284b82 into main Sep 24, 2025
7 checks passed
@kuhe kuhe deleted the fix/schema branch September 24, 2025 17:49
Copy link

github-actions bot commented Oct 9, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants