-
Notifications
You must be signed in to change notification settings - Fork 55
feat: basic annotation processing #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 72 commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
d107a6c
Working
lauzadis 2c3b746
Add a comment
lauzadis 84cb888
ktlint
lauzadis b7b6c5b
cleaning up
lauzadis c4a13ed
Add a comment
lauzadis fb145a8
Undo changes to BuilderRenderer
lauzadis 1d0a599
Disable plugin test package (for now)
lauzadis bf459be
Bump network timeout for downloading Gradle
lauzadis c8830bc
Update comment
lauzadis 3fff3df
ktlint
lauzadis 1a2966b
revert
lauzadis 524858c
clean up
lauzadis 22a6ffe
fill out test
lauzadis ed889da
Fix rendering schema
lauzadis e94033e
Merge branch 'feat-ddb-mapper' of github.com:awslabs/aws-sdk-kotlin i…
lauzadis d627e30
Merge branch 'feat-ddb-mapper' of github.com:awslabs/aws-sdk-kotlin i…
lauzadis 9707eb8
PR feedback
lauzadis 4edb573
ktlint
lauzadis d7547d3
rename plugin extension
lauzadis b876ada
use default `false` member for `mutable` `Member`
lauzadis 00e93a5
Fix new attributes
lauzadis 6bc65fa
Commonize and remove unnecessary test
lauzadis 0cbd2a8
commonize GradleRunner
lauzadis 4e4e473
revert UserTest
lauzadis d232651
Add more codegen options
lauzadis a4fe6bc
All codegen options are working
lauzadis e5cd349
ktlintFormat
lauzadis 9b2d135
Add TestKit tests for all codegen options
lauzadis d6fb875
ktlint
lauzadis 3cc951a
clean up
lauzadis a2bcaec
ktlint
lauzadis 9b9de55
Update KDocs
lauzadis 8abda74
Add more KDocs
lauzadis 6c49b8f
Running unit tests
lauzadis 8ebc112
ktlint
lauzadis b503c15
Add KDocs
lauzadis dc30dfb
Implicit -> empty string
lauzadis 9a58f5c
ktlint
lauzadis 29d77c9
Commit latest
lauzadis 6ce008d
Merge branch 'feat-ddb-mapper' of github.com:awslabs/aws-sdk-kotlin i…
lauzadis ae26243
Fix merge
lauzadis 633268a
Commit latest
lauzadis 5cad5bb
Get tests passing again
lauzadis 74a6157
ListConverter
lauzadis 731a679
ktlintformat
lauzadis 80b8107
revert old changes
lauzadis 43dc70c
Remove Dependencies.ALL_FILES in annotation processor
lauzadis f7bdf42
start work on configurable unknown attributes behavior
lauzadis bf216d6
Delete AnnotatedClassProperty
lauzadis 537463d
Latest
lauzadis b49ff7e
ktlintFormat
lauzadis 9f55f5a
Remove logs
lauzadis 329ac7b
Update comment
lauzadis 8cc75cc
Simplification
lauzadis 8b19546
Save latest changes
lauzadis 57c5f13
temp. commit
lauzadis a43e506
Merge branch 'feat-ddb-mapper' of github.com:awslabs/aws-sdk-kotlin i…
lauzadis 8b989b9
Fix merge
lauzadis 7481db6
ktlint
lauzadis f287fd5
Latest
lauzadis ee115d5
ktlintFormat
lauzadis b0e6b2b
1st pass
lauzadis 976e9eb
Commonize `SchemaAttributes` and compare using `TypeRef` instead of p…
lauzadis 57b7fea
Extract `shouldRenderValueConverter` to extension function
lauzadis 39651f5
Fix parenthesis and args hacks
lauzadis c9cdf85
ktlint
lauzadis fc763db
api changes
lauzadis 1974963
ItemConverter implements Converter<T, Item> and generate usage of Ite…
lauzadis b075c92
ktlintFormat
lauzadis 4afaf33
Fix compile
lauzadis fe84aa6
Clean up rendering value converter
lauzadis 7f667b8
Zip
lauzadis 232b858
Remove removeSuffix
lauzadis 7144d0c
Remove comment
lauzadis 295aa45
Merge branch 'feat-ddb-mapper' of github.com:awslabs/aws-sdk-kotlin i…
lauzadis f45548d
revert back to zip
lauzadis eaab8cd
remove unnecessary parens
lauzadis 10044f6
Add KDocs
lauzadis dff75e4
isGenericFor
lauzadis 87f8d03
refactor renderValueConverter as a non-extension function
lauzadis d1ff053
ktlintFormat
lauzadis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...otlin/aws/sdk/kotlin/hll/dynamodbmapper/codegen/annotations/rendering/SchemaAttributes.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| package aws.sdk.kotlin.hll.dynamodbmapper.codegen.annotations.rendering | ||
|
|
||
| import aws.smithy.kotlin.runtime.collections.AttributeKey | ||
|
|
||
| /** | ||
| * Internal schema code generation attributes | ||
| */ | ||
| internal object SchemaAttributes { | ||
| /** | ||
| * Whether a value converter should be generated for the class being processed | ||
| */ | ||
| internal val ShouldRenderValueConverterAttribute: AttributeKey<Boolean> = AttributeKey("ShouldRenderValueConverter") | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Parentheses around
propType.arguments.anycall are unnecessary