feat: setup DynamoDbMapper publication #1419

lauzadis · 2024-09-26T13:56:46Z

This PR sets up DynamoDBMapper and other related libraries for publication. It also removes the dynamodb-mapper-annotation-processor-test module since it's now duplicated by SchemaGeneratorPluginTest

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…nto feat-ddb-publish

github-actions · 2024-09-26T20:41:39Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK

github-actions · 2024-10-01T21:11:41Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK

ianbotsf · 2024-10-01T21:05:42Z

hll/build.gradle.kts

+@OptIn(InternalApi::class)
+fun getHllPreviewVersion() = if (sdkVersion.contains("-SNAPSHOT")) { // i.e. 1.3.29-beta-SNAPSHOT
+    sdkVersion
+        .removeSuffix("-SNAPSHOT")
+        .ensureSuffix("-beta-SNAPSHOT")
+} else {
+    sdkVersion.ensureSuffix("-beta") // i.e. 1.3.29-beta
+}


Nit: "i.e." → "e.g."

ianbotsf · 2024-10-01T21:07:05Z

hll/build.gradle.kts

+@OptIn(InternalApi::class)
+fun getHllPreviewVersion() = if (sdkVersion.contains("-SNAPSHOT")) { // i.e. 1.3.29-beta-SNAPSHOT
+    sdkVersion
+        .removeSuffix("-SNAPSHOT")
+        .ensureSuffix("-beta-SNAPSHOT")
+} else {
+    sdkVersion.ensureSuffix("-beta") // i.e. 1.3.29-beta
+}


Question: Any reason not to make this a val instead of a fun?

ianbotsf · 2024-10-01T21:08:46Z

hll/hll-codegen/build.gradle.kts

-val sdkVersion: String by project
-group = "aws.sdk.kotlin"
-version = sdkVersion
-


Question: What version will hll-codegen use now?

It gets the version from the parent module hll: https://github.com/awslabs/aws-sdk-kotlin/pull/1419/files/fdf75ed58ff28d75e36f8d52662480a0c3d72ff1#diff-bc29db26a69fa060c49b8d3399f5ee9eb8014006435f213e5f424c0b0656be7eR47

OK so we'll just re-add version = sdkVersion when it comes time to GA the mapper?

Yes and it's set up so we just have to change it in that one spot

ianbotsf · 2024-10-01T21:10:58Z

hll/dynamodb-mapper/dynamodb-mapper-schema-generator-plugin/build.gradle.kts

+import aws.smithy.kotlin.runtime.InternalApi
+import aws.smithy.kotlin.runtime.text.ensureSuffix


Question: How are these imports resolvable by the build script? Do we have the SDK/Smithy runtime in the classpath at this point?

Not sure why it works like this, but we do have a dependency on smithy-kotlin:runtime-core in this module, and the imports to resolve

0marperez · 2024-10-02T13:42:45Z

hll/build.gradle.kts

+subprojects {
+    group = "aws.sdk.kotlin"
+    version = getHllPreviewVersion()
+    configurePublishing("aws-sdk-kotlin")
+}
+
 subprojects {
    if (!needsKmpConfigured) {
        return@subprojects
    }


Question: Why was group, version, and configurePublishing refactored into a second subprojects block?

All subprojects should have those values configured, they are not KMP-specific which is what the pre-existing block is for

0marperez · 2024-10-02T13:53:34Z

hll/dynamodb-mapper/dynamodb-mapper-schema-generator-plugin/build.gradle.kts

 // FIXME Commonize the following functions into the aws-kotlin-repo-tools build-support
+val sdkVersion: String by project
+
+@OptIn(InternalApi::class)
+fun getHllPreviewVersion() = if (sdkVersion.contains("-SNAPSHOT")) { // i.e. 1.3.29-beta-SNAPSHOT
+    sdkVersion
+        .removeSuffix("-SNAPSHOT")
+        .ensureSuffix("-beta-SNAPSHOT")
+} else {
+    sdkVersion.ensureSuffix("-beta") // i.e. 1.3.29-beta
+}
+


Question: When commonizing this function I'm assuming we'll also commonize the other declaration of getHllPreviewVersion()?

Nit: If so can we add a // FIXME or a // TODO to the other instance to remind us

Personally I don't think this function will last long enough, it should be removed once we GA the DynamoDbMapper

0marperez · 2024-10-02T13:56:38Z

hll/dynamodb-mapper/dynamodb-mapper-schema-generator-plugin/build.gradle.kts

+    tasks.withType<PublishToMavenRepository> {
+        dependsOn(tasks.named("javadocJar"))
+    }
+
+    tasks.named("publishDynamodb-mapper-schema-generatorPluginMarkerMavenPublicationToMavenLocal") {
+        dependsOn(tasks.named("javadocJar"))
+    }
+
+    tasks.findByName("signDynamodb-mapper-schema-generatorPluginMarkerMavenPublication")
+        ?.dependsOn(tasks.named("javadocJar"))


Nit: Refactor tasks.named("javadocJar") into a val

sonarqubecloud · 2024-10-02T18:17:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-02T18:26:27Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK

…lin (#1451) * initial poc commit of DynamoDB Mapper (#1232) * add support for Mapper initialization (#1237) * implement mapper pipeline (#1266) * initial implementation of codegen for low-level operations/types (#1357) * initial implementation of secondary index support (#1375) * Create new codegen module and refactor annotation processor to use it (#1382) * feat: add Schema generator Gradle plugin (#1385) * Fix plugin test package * add attribute converters for "standard" values (#1381) * fix: schema generator plugin test module (#1394) * feat: annotation processor codegen configuration (#1392) * feat: add `@DynamoDbIgnore` annotation (#1402) * DDB Mapper filter expressions (runtime components) (#1401) * feat: basic annotation processing (#1399) * add DSL overloads, paginators, and better builder integration for DDB Mapper ops codegen (#1409) * chore: split dynamodb-mapper-codegen into two modules (#1414) * emit DDB_MAPPER business metric (#1426) * feat: setup DynamoDbMapper publication (#1419) * DDB Mapper filter expressions (codegen components) (#1424) * correct docs * mark every HLL/DDBM API experimental (#1428) * fix accidental inclusion of expression attribute members in high-level DynamoDB Mapper requests (#1432) * Upgrade to latest build plugin version * fix: various issues found during testing (#1450) * chore: update Athena changelog notes for 1.3.57 (2024-10-18) release (#1449) * feat: update AWS API models * feat: update AWS service endpoints metadata * chore: release 1.3.60 * chore: bump snapshot version to 1.3.61-SNAPSHOT * feat: initial release of Developer Preview of DynamoDB Mapper for Kotlin * Fix Kotlin gradle-plugin version * fix: ddb mapper tests (#1453) * Bump build plugin version --------- Co-authored-by: Matas <[email protected]> Co-authored-by: aws-sdk-kotlin-ci <[email protected]>

lauzadis added 10 commits September 23, 2024 14:35

Saving changes

b5582b8

Merge branch 'feat-ddb-mapper' of github.com:awslabs/aws-sdk-kotlin i…

ea26cf9

…nto feat-ddb-publish

Latest

5a55ba7

Configure task dependencies for publication

23178a8

ktlintFormat

74e1d12

clean up

7be214b

-preview suffix

307443d

Latest

cae3faa

ktlint

dffb9b4

revert plugin version

a6cc242

lauzadis added 2 commits October 1, 2024 14:29

Bump plugin version

7f8c9b6

Fix an implicit dependency on signing task

eacd39d

lauzadis changed the title ~~Feat ddb publish~~ feat: setup DynamoDbMapper publication Oct 1, 2024

lauzadis marked this pull request as ready for review October 1, 2024 21:01

lauzadis requested a review from a team as a code owner October 1, 2024 21:01

Merge branch 'feat-ddb-mapper' into feat-ddb-publish

fdf75ed

ianbotsf reviewed Oct 1, 2024

View reviewed changes

0marperez reviewed Oct 2, 2024

View reviewed changes

i.e. -> e.g.

b75dbb9

ianbotsf approved these changes Oct 2, 2024

View reviewed changes

0marperez approved these changes Oct 2, 2024

View reviewed changes

Make hllPreviewVersion a val

aa38515

lauzadis merged commit 997a9f6 into feat-ddb-mapper Oct 3, 2024
11 checks passed

lauzadis deleted the feat-ddb-publish branch October 3, 2024 15:23

		import aws.smithy.kotlin.runtime.InternalApi
		import aws.smithy.kotlin.runtime.text.ensureSuffix

feat: setup DynamoDbMapper publication #1419

feat: setup DynamoDbMapper publication #1419

Uh oh!

Conversation

lauzadis commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue #

Description of changes

Uh oh!

github-actions bot commented Sep 26, 2024

Uh oh!

github-actions bot commented Oct 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lauzadis Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 2, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Oct 2, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lauzadis commented Sep 26, 2024 •

edited

Loading

lauzadis Oct 2, 2024 •

edited

Loading