Skip to content

feat: smoke tests #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Oct 4, 2024
Merged

feat: smoke tests #1427

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
602bac1
feat: smoke tests
0marperez Aug 23, 2024
989d8ec
Merge branch 'main' of https://github.com/awslabs/aws-sdk-kotlin into…
0marperez Aug 23, 2024
9ca8f2e
Sending verified commit to trigger CI
0marperez Aug 23, 2024
b00ec1f
Actually sign commit message[B
0marperez Aug 23, 2024
35708df
PR feedback
0marperez Aug 28, 2024
2399355
Remove error log commited by accident
0marperez Aug 28, 2024
2d98a99
Add TODO
0marperez Aug 28, 2024
d7a4877
Added E2E tests
0marperez Sep 13, 2024
f390f6a
Remove dangerous gradle task, move sdk denylist check to codegen inst…
0marperez Sep 17, 2024
90a93ac
Fix kotlin native builds failing
0marperez Sep 18, 2024
6b288ed
Temp print statement to debug
0marperez Sep 18, 2024
c6701cb
Change debugging print to exception
0marperez Sep 18, 2024
95b553d
chmod gradlew before tests
0marperez Sep 18, 2024
5ac3db2
Use gradlew.bat
0marperez Sep 19, 2024
ca30211
ls sdk root dir
0marperez Sep 19, 2024
08356db
Use gradle connector instead of process builder
0marperez Sep 20, 2024
e7fdeff
build before testing
0marperez Sep 20, 2024
8f0dec1
increase gradle connection timeout
0marperez Sep 20, 2024
431e63e
run from sdk root dir, better logging, use explicit gradle distributi…
0marperez Sep 20, 2024
1706764
Enable gradle daemon with an idle timeout, increment internal timeout
0marperez Sep 21, 2024
bb53c3d
use gradle runner instead of connector
0marperez Sep 22, 2024
e13e9fc
Specify smokeTests to run & better test failure logging
0marperez Sep 22, 2024
afc5168
fix parallel task execution issues
0marperez Sep 22, 2024
c39f3fe
move task dependency from ci tests to code
0marperez Sep 23, 2024
5dfd004
easy to fix PR feedback and decoupling SmokeTestRunnerGenerator from SDK
0marperez Sep 23, 2024
87fa6bb
Merge branch 'main' of https://github.com/awslabs/aws-sdk-kotlin into…
0marperez Sep 23, 2024
c1e0edf
Remove accidental changes to AWS model
0marperez Sep 24, 2024
dfcffbb
Run smoke tests in common
0marperez Sep 24, 2024
25b8e8e
Self nits
0marperez Sep 24, 2024
8aae6e4
Use new runtime function for env vars
0marperez Sep 24, 2024
5687f7e
Cleanup, Clarity changes to test code in src
0marperez Sep 25, 2024
1e35fc7
Merge from main
0marperez Oct 2, 2024
d465c50
Disable native for smoke test e2e tests
0marperez Oct 3, 2024
73f694a
Use vararg instead of list & add FIXME to enable native builds later
0marperez Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/codegen/smoke-tests/src/test/kotlin/SmokeTestE2ETest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ private fun runSmokeTests(service: String, envVars: Map<String, String> = emptyM
val sdkRootDir = System.getProperty("user.dir") + "/../../../"
val runner = GradleRunner.create()
.withProjectDir(File(sdkRootDir))
.withArguments(":tests:codegen:smoke-tests:services:$service:smokeTest")
.withArguments(listOf("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest"))
Copy link
Member

@lauzadis lauzadis Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Copy link
Contributor Author

@0marperez 0marperez Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ianbotsf ianbotsf Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: A vararg overload of withArguments exists so listOf could be removed.

.withArguments("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest")

Copy link
Contributor

@ianbotsf ianbotsf Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we have a task or something that tracks removing all the places we've disabled native builds? If not, I suggest we add a FIXME or something else here to increase the likelihood we remember to remove this once Kotlin/Native is ready.

Copy link
Contributor Author

@0marperez 0marperez Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I added a subtask to our Kotlin Native task so we remember.

.withEnvironment(envVars)
.build()

Expand Down
Loading