feat: aws smoke tests support #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… smoke-tests-trait
… smoke-tests-trait
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Oct 9, 2024
| ) | ||
|
|
||
| /** | ||
| * Uses the AWS Kotlin SDK specific way of configuring `accountIdEndpointMode` |
There was a problem hiding this comment.
nit/confusing:
AWS Kotlin SDK specific way
simplified:
Configures
accountIdEndpointModeon an SDK client
Same comment applies to other section writers
Comment on lines
146
to
150
| private val useGlobalEndpointSectionWriters = listOf( | ||
| SectionWriterBinding(SmokeTestUseGlobalEndpoint) { writer, _ -> | ||
| writer.write("// Smoke tests modeled the use of `useGlobalEndpoint` config, but it's not supported by the SDK") | ||
| }, | ||
| ) |
There was a problem hiding this comment.
I think throwing an exception would be safer. What if the smoke test is dependent on this useGlobalEndpoint config option being set/supported, and it will otherwise fail?
| ) | ||
|
|
||
| /** | ||
| * Ensures we use the provided URI |
There was a problem hiding this comment.
consistency: Configures static endpoint on an SDK client
… smoke-tests-trait
… smoke-tests-trait
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Nov 6, 2024
| "useAccelerate" -> "enableAccelerate" | ||
| "useMultiRegionAccessPoints" -> "disableMrap" | ||
| "useGlobalEndpoint" -> { | ||
| writer.write("throw Exception(#S)", "'useGlobalEndpoint' is not supported by the SDK") |
There was a problem hiding this comment.
Exception should be #T and can probably be a better exception type
| */ | ||
| val defaultClientConfig = | ||
| SectionWriterBinding(DefaultClientConfig) { writer, previous -> | ||
| writer.write("#L", previous) |
There was a problem hiding this comment.
I added previous just in case we add more default client config in the future via another SectionWriterBinding
Comment on lines
80
to
91
| resolutionStrategy { | ||
| val sdkVersion: String by settings | ||
| eachPlugin { | ||
| if (requested.id.id == "aws.sdk.kotlin.hll.dynamodbmapper.schema.generator") { | ||
| useModule("aws.sdk.kotlin:dynamodb-mapper-schema-generator-plugin:$sdkVersion") | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencyResolutionManagement { | ||
| repositories { | ||
| mavenLocal() | ||
| mavenCentral() | ||
| } | ||
| } | ||
|
|
||
| rootProject.name = "aws-sdk-kotlin" | ||
|
|
||
| includeBuild("build-support") |
There was a problem hiding this comment.
I think this is leftover from a merge from main while DDB mapper was in development. I'll get rid of it
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Nov 7, 2024
|
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Reintroduces aws smoke tests support after revert
Companion PR: smithy-lang/smithy-kotlin#1160
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.