-
Notifications
You must be signed in to change notification settings - Fork 55
misc: credentials business metrics #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0marperez
merged 20 commits into
credentials-chain-order
from
credentials-business-metrics
Nov 4, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
faee8bb
misc: emit credentials business metrics
0marperez a50e692
Profile credentials business metrics tests
0marperez 8d61e07
Bug fixes around business metrics
0marperez 18c80e7
Added business metrics to default chain credentials provider tests
0marperez 8244764
Self review
0marperez 9c3967c
Allow running protocol tests with snapshot smithy kotlin versions
0marperez 92e091e
Revert previous commit
0marperez a4e5eca
Naming changes
0marperez 1a51409
Fix CODE_CREDENTIALS metric to only emit when static credntials provi…
0marperez d7ba2b9
Refactor CREDENTIALS_ENV_VARS_STS_WEB_ID_TOKEN business metrics out o…
0marperez 668ed18
Move credential business metric emission to credentials return time
0marperez 1bdaa80
Remove duplicate test coverage & newline in LazilyInitializedCredenti…
0marperez 03ca91f
Refactor ProfileCredentialsProvider, unused function param, and reada…
0marperez 6a7b812
Move credentials business metrics to credentials attributes
0marperez 02db28d
Add JvmName import that didn't cause build failures when missing loca…
0marperez b74a50b
Remove breaking changes from smithy kotlin
0marperez 864dc65
Set<String> -> Set<BusinessMetric> business metrics
0marperez 82c7a3f
Self review
0marperez 573facd
Self review & refactoring
0marperez 85b78d7
PR feedback
0marperez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 0 additions & 24 deletions
24
...ommon/src/aws/sdk/kotlin/runtime/auth/credentials/LazilyInitializedCredentialsProvider.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness:
MutableSetdoes not guarantee order of elementsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually does
From
MutableSet:From
LinkedHashSet:You can double check we're using
LinkedHashSetby getting the::class.simpleNameof the business metricsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the current implementation, but it's not guaranteed and could change in a future version of Kotlin. It's unlikely, and I'm open to keeping this
MutableSetbut just wanted to call it out 🤷