chore: add support for SESv2 Sigv4a (not yet used because SESv2 hasn't rolled out support) #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t rolled out support)
ianbotsf
added
the
no-changelog
lauzadis
approved these changes
Oct 25, 2024
| class Sigv4aTest { | ||
| @Test | ||
| @Ignore // TODO enable once SESv2 model adds endpointId and Sigv4a | ||
|
|
| }.use { ses -> | ||
| assertFailsWith<HttpException> { | ||
| ses.sendEmail { | ||
| // endpointId = "bdm3x3zl.n5x" // TODO uncomment |
There was a problem hiding this comment.
Will this TODO be completed in this PR?
There was a problem hiding this comment.
No, we'll need to follow up. There's no public issue to track for doing so.
| assertEquals(1, interceptor.requests.size) | ||
| val request = interceptor.requests.single() | ||
|
|
||
| assertContains("bdm3x3zl.n5x.endpoints.email.amazonaws.com", request.url.host.toString()) // Correct endpoint? |
There was a problem hiding this comment.
Yes, it is. The comment is probably misleading now, I'll update it.
|
0marperez
approved these changes
Oct 25, 2024
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
This change prepares for SESv2 Sigv4a support. This won't take effect until additional support rolls out from the service side.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.