-
Notifications
You must be signed in to change notification settings - Fork 55
fix: overhaul endpoint discovery #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…make endpoint discoverers interfaces so custom implementations can be provided, and to respect environmental config
|
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
| ) | ||
| } | ||
|
|
||
| fun assertEpDiscovery( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Nice tests! It would be cool to make this test suite config option agnostic so we can have an easy way to test new config options.



Issue #
Addresses #1413
Description of changes
This change catches up to EP discovery changes in smithy-lang/smithy-kotlin#1221 and also adds support for resolving endpoint discovery mode from environmental config.
Companion PR: smithy-lang/smithy-kotlin#1221
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.