Skip to content

fix: enhance smoke test debuggability by echoing build output from inner Gradle runner #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: enhance smoke test debuggability by echoing build output from inner Gradle runner #1519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...gen/smoke-tests/src/test/kotlin/aws/sdk/kotlin/test/codegen/smoketest/SmokeTestE2ETest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ class SmokeTestE2ETest {

assertContains(smokeTestRunnerOutput, "not ok ExceptionService ExceptionTest - no error expected from service")
assertContains(smokeTestRunnerOutput, "#aws.smithy.kotlin.runtime.http.interceptors.SmokeTestsFailureException: Smoke test failed with HTTP status code: 400")
assertContains(smokeTestRunnerOutput, "#\tat aws.smithy.kotlin.runtime.http.interceptors.SmokeTestsInterceptor.readBeforeDeserialization(SmokeTestsInterceptor.kt:19)")
assertContains(smokeTestRunnerOutput, "#\tat aws.smithy.kotlin.runtime.http.interceptors.InterceptorExecutor.readBeforeDeserialization(InterceptorExecutor.kt:252)")
Comment on lines -37 to -38
Copy link
Member

@lauzadis lauzadis Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we lose the stack trace with this change?

Copy link
Contributor Author

@ianbotsf ianbotsf Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lost the stack trace assertion with this change. Asserting on stack traces is brittle and adds no value to this test. I'd remove other parts of the exception message assertions as well but that would be a larger refactor so for now I'm just removing this.

}

@Test
Expand Down Expand Up @@ -72,6 +70,7 @@ private fun runSmokeTests(
":tests:codegen:smoke-tests:services:$service:smokeTest",
)
.withEnvironment(envVars)
.forwardOutput()

val buildResult = if (expectingFailure) task.buildAndFail() else task.build()

Expand Down
Loading