Skip to content

Conversation

@ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Mar 7, 2025

Issue #

(none)

Description of changes

Well kat metrics emit is being now being invoked correctly but throws an error because duration isn't being stored properly. Example run:

Executing command "kat metrics emit --namespace "CI Metrics" --dimension "Product=aws-sdk-kotlin" --dimension "Trigger=manual" --metric "ReleaseMergeAttempted:1:Count" --metric "ReleaseMergeSucceeded:1:Count" --metric "ReleaseMergeCanceled:0:Count" --metric "ReleaseMergeFailed:0:Count" --metric "ReleaseMergeDuration::Seconds""
Usage: kat metrics emit [<options>]

Error: invalid value for --metric: Invalid numerical metric value ''

(Note that ReleaseMergeDuration::Seconds contains no value)

Hopefully this is the final fix!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Mar 7, 2025
@ianbotsf ianbotsf requested a review from a team as a code owner March 7, 2025 23:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

Affected Artifacts

No artifacts changed size

@lauzadis lauzadis merged commit 165bff0 into main Mar 11, 2025
22 of 25 checks passed
@lauzadis lauzadis deleted the chore-updatereleasebranch-duration-fix branch March 11, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants