Skip to content

Conversation

@lauzadis
Copy link
Member

@lauzadis lauzadis commented Apr 9, 2025

I am working on getting Kotlin/Native "working" in CI. svc-check-batch will need to have aws.kotlin.native=false for now, for a few reasons.

Adding aws.kotlin.native=false to svc-check-batch today yields an error when running ./gradlew -Paws.kotlin.native=false artifactSizeMetrics:

> Task :hll:dynamodb-mapper:dynamodb-mapper:metadataSourcesJar FAILED

[Incubating] Problems report is available at: file:///Users/lauzmata/aws-sdk-kotlin/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':hll:dynamodb-mapper:dynamodb-mapper:metadataSourcesJar' (type 'Jar').
  - Gradle detected a problem with the following location: '/Users/lauzmata/aws-sdk-kotlin/hll/dynamodb-mapper/dynamodb-mapper/build/generated/ksp/common/commonMain/kotlin'.

    Reason: Task ':hll:dynamodb-mapper:dynamodb-mapper:metadataSourcesJar' uses this output of task ':hll:dynamodb-mapper:dynamodb-mapper:moveGenSrc' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':hll:dynamodb-mapper:dynamodb-mapper:moveGenSrc' as an input of ':hll:dynamodb-mapper:dynamodb-mapper:metadataSourcesJar'.
      2. Declare an explicit dependency on ':hll:dynamodb-mapper:dynamodb-mapper:moveGenSrc' from ':hll:dynamodb-mapper:dynamodb-mapper:metadataSourcesJar' using Task#dependsOn.
      3. Declare an explicit dependency on ':hll:dynamodb-mapper:dynamodb-mapper:moveGenSrc' from ':hll:dynamodb-mapper:dynamodb-mapper:metadataSourcesJar' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.12.1/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

We've seen this error before and already fixed the implicit dependency for jvmSourcesJar. This PR also fixes implicit dependencies for metadataSourcesJar which only comes up when running the artifactSizeMetrics task

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner April 9, 2025 00:24
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Apr 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Affected Artifacts

No artifacts changed size

@lauzadis lauzadis merged commit 5373fb2 into main Apr 9, 2025
19 checks passed
@lauzadis lauzadis deleted the misc-fix-implicit-dependency branch April 9, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants