misc: minimize artifact-size comments if the size increase is acknowledged #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
lauzadis
added
the
acknowledge-artifact-size-increase
This comment has been minimized.
This comment has been minimized.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
0marperez
approved these changes
Apr 10, 2025
|
Closing in favor of commonized script: aws/aws-kotlin-repo-tools#84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the artifact size increase is acknowledged, the comments should all be minimized. This came up while working on #1555. There was a size increase across many artifacts, I acknowledged the increase, but the bot still left massive comments which slowed down my browser performance.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.