-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add analytics to api ref docs #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
ianbotsf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback, fix and ship!
| assumeTrue( | ||
| testFile.exists(), | ||
| "Skipping test: test file does not exist", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We should not skip the test if the test file doesn't exist. We should fail (i.e., assertTrue).
gradle/libs.versions.toml
Outdated
| kotlinx-serialization-version = "1.7.3" | ||
| mockk-version = "1.13.13" | ||
| slf4j-version = "2.0.16" | ||
| jsoup-version = "1.19.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The latest release is 1.20.1
|
A new generated diff is ready to view.
|
|
|
A new generated diff is ready to view.
|
Affected ArtifactsChanged in size
|



Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.