Skip to content

kn: properly memscope executeCommand #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

kn: properly memscope executeCommand #1592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ccc208
Properly memscope execution
lauzadis May 8, 2025
9669917
Fully qualify shell path
lauzadis May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...ime/aws-config/native/src/aws/sdk/kotlin/runtime/auth/credentials/executeCommandNative.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,19 @@ internal actual suspend fun executeCommand(
}

val shell = when (platformProvider.osInfo().family) {
OsFamily.Windows -> "cmd.exe"
else -> "sh"
OsFamily.Windows -> "C:\\\\Windows\\\\System32\\\\cmd.exe"
Copy link
Contributor

@ianbotsf ianbotsf May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why are these backslashes double escaped?

Copy link
Member Author

@lauzadis lauzadis May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelling in favor of #1593. I don't think they should be double escaped.

else -> "/bin/sh"
}

val shellArg = when (platformProvider.osInfo().family) {
OsFamily.Windows -> "/C"
else -> "-c"
}

val argv = memScoped { (arrayOf(shell, shellArg, command).map { it.cstr.ptr } + null).toCValues() }
execvp(shell, argv)
memScoped {
val argv = (arrayOf(shell, shellArg, command).map { it.cstr.ptr } + null).toCValues()
execvp(shell, argv)
}
_exit(127) // If exec fails
}

Expand Down
Loading