fix: correctly convert key fields during paginated Scan and Query operations
#1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
commented
Jun 16, 2025
Comment on lines
10
to
11
| import aws.smithy.kotlin.runtime.ExperimentalApi | ||
| import kotlin.jvm.JvmName | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Comment: No clue why this is no longer necessary. 🤷♂️
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Jun 17, 2025
…key-attributes-only scenario
|
|
A new generated diff is ready to view.
|
Affected ArtifactsNo artifacts changed size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Resolves #1596
Description of changes
This change corrects an oversight in key field conversion, namely relying on
ItemConverterimplementations to respect and properly handle theonlyAttributesargument. Given that implementations may vary widely and come from untrusted/unmodifiable sources, this change manually trims post-conversion key fields to retain only key attributes (dropping non-key attributes). Currently this affects four parameters:DeleteItemRequest.keyGetItemRequest.keyQueryRequest.exclusiveStartKeyScanRequest.exclusiveStartKeyThis should eliminate service errors when sending too many fields in the above operations requests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.