docs: fix navigation links on left sidebar #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
added
the
no-changelog
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
ianbotsf
reviewed
Jun 21, 2025
Contributor
There was a problem hiding this comment.
Correctness: Why are we deleting this file?
Member
Author
There was a problem hiding this comment.
This e2e test fails with
java.lang.IllegalStateException: Unexpected response Failure(java.lang.IllegalStateException: Unexpected response Failure(aws.sdk.kotlin.services.timestreamwrite.model.TimestreamWriteException: Only existing Timestream for LiveAnalytics customers can access the service. Reach out to AWS support, for more information.))
Member
Author
There was a problem hiding this comment.
~~I should have deleted the test for timestreamwrite, not timestreamquery, fixed that. ~~
edit: both timestreamwrite and timestreamquery need to be disabled
This comment has been minimized.
This comment has been minimized.
… E2E test" This reverts commit 66ec97b.
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Jun 21, 2025
…, remove E2E test"" This reverts commit 958657f.
|
|
A new generated diff is ready to view. |
Affected ArtifactsNo artifacts changed size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with our latest docs' left sidebar:
extractModulePathused the presence of periods to detect the module name, which failed for versioned docs, which use periods in the version number... simplified function implementation to fix this../). Dokka already handles these in their navigation loader, we need to prune all the parent directory elements rather than just some of themIssue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.