-
Notifications
You must be signed in to change notification settings - Fork 55
feat: update to IMDS credentials provider SEP v2.1.1 #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsChanged in size
|
| @InternalSdkApi | ||
| public val AwsProfile.ec2MetadataDisabled: Boolean? | ||
| get() = getBooleanOrNull("disable_ec2_metadata") | ||
| get() = getBooleanOrNull("ec2_metadata_disabled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying these config options is a breaking change, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it would be. I'm cancelling this PR for now due to other factors but should it be revived in the future, we'll need to check both the old (incorrect) key and the new key.



Issue #
(none)
Description of changes
This change updates to the latest specification for IMDS credentials providers (SEP 2.1.1):
disableEc2Metadata→ec2MetadataDisableddisable_ec2_metadata→ec2_metadata_disabledBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.