-
Notifications
You must be signed in to change notification settings - Fork 55
chore: remove @deprecated APIs in preparation for v1.5
#1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
A new generated diff is ready to view.
|
Affected ArtifactsChanged in size
|
| @Deprecated("This constructor passes HTTP status as an Int instead of as HttpStatusCode. This declaration will be removed in version 1.6.x.") | ||
| public constructor(statusCode: Int, message: String) : this(HttpStatusCode.fromValue(statusCode), message) | ||
|
|
||
| @Deprecated("This property is now deprecated and should be fetched from status.value") | ||
| @Deprecated("This property is now deprecated and should be fetched from status.value. This declaration will be removed in version 1.6.x.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we kept these? We've removed other APIs in this PR which were only @Deprecated with no version referenced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I feel these deprecations were added too close to the v1.5 launch and it'd be unfair to remove them too quickly.



Issue #
(none)
Description of changes
Removes
@DeprecatedAPIs from the runtime modules in preparation for v1.5 release.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.