chore: refactor trimNavigationFiles task to use Gradle Worker API to improve performance #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improve performance
ianbotsf
added
the
no-changelog
ianbotsf
commented
Oct 20, 2025
Comment on lines
+62
to
+90
| val doc = Jsoup.parse(navigation) | ||
|
|
||
| // Remove all parent directory elements from all navigation links | ||
| doc.select("a[href^=../]").forEach { anchor -> | ||
| var href = anchor.attr("href") | ||
|
|
||
| while (href.startsWith("../")) { | ||
| href = href.removePrefix("../") | ||
| } | ||
|
|
||
| anchor.attr("href", href) | ||
| } | ||
|
|
||
| // Trim side menus | ||
| doc.select("div.sideMenu > div.toc--part") | ||
| .filterNot { it.id().startsWith("$moduleName-nav-submenu") } | ||
| .forEach { moduleMenu -> | ||
| val moduleRow = moduleMenu.select("div.toc--row").first()!! | ||
| val toggleButton = moduleRow.select("button.toc--button").single() | ||
| toggleButton.remove() | ||
|
|
||
| moduleMenu.children() | ||
| .filterNot { it == moduleRow } | ||
| .forEach { it.remove() } | ||
| } | ||
|
|
||
| // Update navigation.html | ||
| val trimmedSideMenuParts = doc.select("div.sideMenu > div.toc--part") | ||
| navigation.writeText("<div class=\"sideMenu\">\n$trimmedSideMenuParts\n</div>") |
There was a problem hiding this comment.
Note for reviewers: This section is copied directly from the old task impl. No non-refactoring changes made.
lauzadis
approved these changes
Oct 20, 2025
|
A new generated diff is ready to view.
|
xinsong-cui
approved these changes
Oct 20, 2025
0marperez
approved these changes
Oct 20, 2025
|
A new generated diff is ready to view.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
This change refactors the
trimNavigationFilestask to improve performance by using the Gradle Worker API. I measured the delta on my dev machine:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.