Skip to content

feat: increase ImdsClient.Builder.engine visibility to public #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

feat: increase ImdsClient.Builder.engine visibility to public #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120e5aa
feat: increase ImdsClient.Builder.engine visibility to public
ianbotsf Oct 31, 2025
d9e550e
api dump
ianbotsf Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/3bc2e0a5-d8d4-4051-a723-a54427a96e7e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"id": "3bc2e0a5-d8d4-4051-a723-a54427a96e7e",
"type": "feature",
"description": "Enable configuring an HTTP engine on `ImdsClient`"
}
2 changes: 2 additions & 0 deletions aws-runtime/aws-config/api/aws-config.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,10 +418,12 @@ public final class aws/sdk/kotlin/runtime/config/imds/ImdsClient : aws/sdk/kotli
public final class aws/sdk/kotlin/runtime/config/imds/ImdsClient$Builder {
public fun <init> ()V
public final fun getEndpointConfiguration ()Laws/sdk/kotlin/runtime/config/imds/EndpointConfiguration;
public final fun getEngine ()Laws/smithy/kotlin/runtime/http/engine/HttpClientEngine;
public final fun getLogMode ()Laws/smithy/kotlin/runtime/client/LogMode;
public final fun getMaxRetries ()I
public final fun getTokenTtl-UwyO8pc ()J
public final fun setEndpointConfiguration (Laws/sdk/kotlin/runtime/config/imds/EndpointConfiguration;)V
public final fun setEngine (Laws/smithy/kotlin/runtime/http/engine/HttpClientEngine;)V
public final fun setLogMode (Laws/smithy/kotlin/runtime/client/LogMode;)V
public final fun setMaxRetries (I)V
public final fun setTokenTtl-LRDsOJo (J)V
Expand Down
4 changes: 2 additions & 2 deletions aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/imds/ImdsClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ public class ImdsClient private constructor(builder: Builder) : InstanceMetadata
public var logMode: LogMode = LogMode.Default

/**
* The HTTP engine to use to make requests with. This is here to facilitate testing and can otherwise be ignored
* The HTTP engine to use to make requests with
*/
internal var engine: HttpClientEngine? = null
public var engine: HttpClientEngine? = null

/**
* The source of time for token refreshes. This is here to facilitate testing and can otherwise be ignored
Expand Down
Loading