Avoid cloning ImmutableCredentials objects.
#3936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
rm-copy-immutable
branch
from
bde4bdb to
62805c4
Compare
teo-tsirpanis
commented
Jul 26, 2025
boblodgett
reviewed
Jul 31, 2025
| "updateMinimum": false, | ||
| "type": "patch", | ||
| "changeLogMessages": [ | ||
| "Avoid cloning \u0060ImmutableCredentials\u0060 objects." |
There was a problem hiding this comment.
I am not positive if our build system will accept \u0060 but I will dry run this PR to determine.
There was a problem hiding this comment.
DRY_RUN-c6382969-8690-4729-a359-43bb125eb338 started
normj
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all calls to the
ImmutableCredentials.Copymethod.Motivation and Context
ImmutableCredentialsobjects are immutable, and thus there is no need to call theCopy()method, which seems to have been added due to an oversight almost 10 years ago.Also, cloning immutable credentials will inhibit caching of the SigV4a signing key (#3923 (comment)).
Testing
Not tested locally
Screenshots (if appropriate)
Types of changes
Checklist
License