Skip to content

Phase 2 final operations #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025
Merged

Phase 2 final operations #3949

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4642adf
Generator changes, and custom code changes
peterrsongg Aug 7, 2025
e19e49d
Generated changes
peterrsongg Aug 7, 2025
5116a9d
update devconfig
peterrsongg Aug 7, 2025
82b4c6d
remove redundant header unmarshalling in getobjectmetadataresponseunm…
peterrsongg Aug 11, 2025
3cef157
Explicitly state in devconfig about nosuchkey exception being thrown
peterrsongg Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion generator/.DevConfigs/79b46eff-9dd1-4281-88f0-22c700a96506.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"serviceName": "S3",
"type": "patch",
"changeLogMessages": [
"Generate PutBucketAcl PutBucketCors,PutObjectAcl, GetObjectAcl, ListObjectsV2, ListVersions, HeadObject"
"Generate PutBucketAcl PutBucketCors,PutObjectAcl, GetObjectAcl, ListObjectsV2, ListVersions, HeadObject.",
"As part of generating S3, all response unmarshallers will implement UnmarshallException. GetObjectACL will now throw NoSuchKeyException if no such key exists. This is not a breaking change."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this cause issues for customers if they are catching UnmarshalException in their code and not handling NoSuchKey?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a customer right now would be catching the generic AmazonS3Exception which will still work because NoSuchKeyException inherits AmazonS3Exception. So, not a breaking change.

]
}
]
Expand Down