make maxinmemorypartsnullable #4279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
approved these changes
Jan 7, 2026
GarrettBeatty
commented
Jan 7, 2026
| get { return this._maxInMemoryParts; } | ||
| set { this._maxInMemoryParts = value; } | ||
| } | ||
| public int? MaxInMemoryParts { get; set; } |
Contributor
Author
There was a problem hiding this comment.
https://github.com/aws/aws-sdk-net/blob/main/sdk/src/Services/S3/Custom/Transfer/TransferUtilityOpenStreamRequest.cs#L35 this property is brand new (not on main) so its safe to update
peterrsongg
approved these changes
Jan 7, 2026
GarrettBeatty
added a commit
that referenced
this pull request
Jan 8, 2026
* Increase multipart upload default part size to 8MB (#4032) * Added PutObjectResponse to TransferUtilityUploadResponse mapping (#4045) * Add missing fields to Transfer Utility request objects (#4056) * Fix issue with HeadersCollection in ResponseMapperTests * Add Progress listeners for initiated, complete, and failed for simple upload (#4059) * Add mapping of CompletemultipartUploadResponse to TransferUtilityUploadResponse (#4060) * Add multipartupload lifecycle tracking (#4061) * fix silently failing test (#4073) * Add ContentLanguage to header collection of GetObjectResponse. (#4074) * ignore isset (#4082) * Add DownloadResponse mapping (#4075) * Add additional validation to UploadPartRequests in Transfer Utility (#4083) * Update Response mapping logic for PutObjectResponse and CompleteMultipartResponse (#4086) * create tuabortmultipartuploadrequest (#4093) * Remove AmazonWebServiceResponse as base class for transfer utility repsonse objects. (#4087) stack-info: PR: #4087, branch: GarrettBeatty/stacked/12 * Add GetObjectResponse to TransferUtilityOpenStreamResponse mapping. (#4076) stack-info: PR: #4076, branch: GarrettBeatty/stacked/9 * Fix Unit test (#4108) * Add UploadWithResponseAsync api (#4105) * Add DownloadInitiated, Failed and Completed events (#4079) * Populate TransferUtilityDownloadDirectoryResponse with total objects downloaded (#4109) * Added UploadWithResponse and UploadWithResponseAsync methods to ITransferUtility interface (#4143) * Update TransferUtilityConfig and BaseDownloadRequest to add multi part download config options (#4120) * Fix content language initialization (#4168) * Multi Part Download + OpenStreamWithResponseAsync (#4130) * DownloadWithResponse with multipartdownload (#4136) * Make AddBuffer non async (#4173) * add failure policy to download directory (#4151) * fix test (#4175) * Add progress tracking for multi part download to files (#4139) * Add DownloadDirectoryWithResponse (#4141) * Optimize part streaming (#4162) * Update initiated, complete and failed events to not fire in background (#4170) * Move MaxInMemoryParts to request object (#4163) * Add error message for multipart download when using Encryption Client (#4171) * add failure policy to upload directory (#4181) * Fix download directory concurrency issue and refactor (#4180) * Update code to acquire capacity before starting task (#4182) * use throttling for discoverpart (#4183) * refactor upload directory and fix concurrency bug (#4186) * DownloadDirectory Initiated, Failed and Completed Events (#4176) * update logging (#4188) * Create UploadDirectoryWithResponse api + progress tracking events + update docs and sync exception handling (#4187) * fix test (#4190) * fix integ test build (#4191) * fix build. (#4192) * remove InternalsVisibleTo for S3 integration tests (#4194) * Fix DownloadPartProgressEventCallback race condition (#4196) * fix http concurrency (#4218) * optimize task creation (#4219) * use max size semaphore (#4220) * fix retrying valid IO exceptions * update dev configs (#4201) * Doc updates (#4229) * refactor (#4233) * code refactor src (#4235) * queue fixes (#4228) * add case sensitivity check to download directory command * Content Language Bug Fix (#4224) * Multi Part Download: Use Chunked Stream (#4231) * cleanup (#4232) * async filestream * Revert "async filestream" This reverts commit 567d815. * make ChunkBufferSize public (#4263) * async filestream (#4264) * update docs (#4265) * update docs * fix typo * Fix doc build (#4268) * Fix doc build * Revert "Fix doc build" This reverts commit 341f50b. * fix doc build * Delete generator/.DevConfigs/f8a7b6c5-d4e3-2f1a-0b9c-8d7e6f5a4b3c.json * Update changelog for S3 UploadWithResponse methods * Improve ArrayPool chunk disposal (#4272) * dispose individual chunks * Add log --------- Co-authored-by: Afroz Mohammed <[email protected]> Co-authored-by: Garrett Beatty <[email protected]> * make filestream not set async options (#4280) * make maxinmemorypartsnullable (#4279) --------- Co-authored-by: Philippe El Asmar <[email protected]> Co-authored-by: Phil Asmar <[email protected]> Co-authored-by: Afroz Mohammed <[email protected]> Co-authored-by: Afroz Mohammed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make maxinmemoryparts nullable in case we want to auto calculate it later on
4367fa3e-b2e5-4110-81be-82d23caff658 dry run