Skip to content

Comments

Cleanup generator and remove s3-instructions.md post s3 generation.#4336

Merged
peterrsongg merged 3 commits intodevelopmentfrom
petesong/cleanup-post-s3-generation
Feb 24, 2026
Merged

Cleanup generator and remove s3-instructions.md post s3 generation.#4336
peterrsongg merged 3 commits intodevelopmentfrom
petesong/cleanup-post-s3-generation

Conversation

@peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Feb 19, 2026

Description

Removing some unused code in the generator and removing s3-instructions.md since s3 generation is complete

Motivation and Context

Cleanup

Testing

dry run 91de9411-a4d5-4ce4-b1cc-265290c52568 pending

Breaking Changes Assessment

  1. Identify all breaking changes including the following details:
    • What functionality was changed?
    • How will this impact customers?
    • Why does this need to be a breaking change and what are the most notable non-breaking alternatives?
    • Are best practices being followed?
    • How have you tested this breaking change?
  2. Has a senior/+ engineer been assigned to review this PR?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

GarrettBeatty
GarrettBeatty previously approved these changes Feb 20, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove this file.

@peterrsongg peterrsongg merged commit 895fd1e into development Feb 24, 2026
6 checks passed
@peterrsongg peterrsongg deleted the petesong/cleanup-post-s3-generation branch February 24, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants