SDK V4 - Add dry-run status fields to PR template#4350
Open
AlexDaines wants to merge 1 commit intodevelopmentfrom
Open
SDK V4 - Add dry-run status fields to PR template#4350AlexDaines wants to merge 1 commit intodevelopmentfrom
AlexDaines wants to merge 1 commit intodevelopmentfrom
Conversation
Add a Dry-run subsection under Testing with structured fields for dry-run ID, status checkboxes, and failed bypass reason. This makes dry-run status an explicit part of every PR, preventing merges with unnoticed failing dry-runs.
| - [ ] Pending | ||
| - [ ] Completed successfully | ||
| - [ ] Failed | ||
| - **Failed bypass reason:** |
Contributor
There was a problem hiding this comment.
i dont think there is ever a valid use case for the failed bypass reason
Contributor
Author
There was a problem hiding this comment.
I think you're probably right. I'll get some clarification as to why that was mentioned in the original DOD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add structured dry-run status fields to the PR template's Testing section. This adds a
### Dry-runsubsection with fields for dry-run ID, status checkboxes (Pending / Completed successfully / Failed), and a failed bypass reason.Motivation and Context
Dry-run status was not visible in the PR template, making it easy for reviewers to miss failing dry-runs before merging. Adding explicit fields ensures dry-run results are documented and reviewed as part of every PR.
Testing
N/A — template-only change. Verified the markdown renders correctly with GitHub checkbox syntax.
Dry-run
Breaking Changes Assessment
No breaking changes — this is a PR template modification only.
Types of changes