Skip to content

Commit 4669aec

Browse files
fix: Config not loading environment variables for config (#2136)
1 parent f8d419b commit 4669aec

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

awswrangler/_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,12 @@ def to_pandas(self) -> pd.DataFrame:
144144
def _load_config(self, name: str) -> bool:
145145
if _CONFIG_ARGS[name].loaded:
146146
self._set_config_value(key=name, value=_CONFIG_ARGS[name].default)
147-
return True
148147

149148
env_var: Optional[str] = os.getenv(f"WR_{name.upper()}")
150149
if env_var is not None:
151150
self._set_config_value(key=name, value=env_var)
152151
return True
152+
153153
return False
154154

155155
def _set_config_value(self, key: str, value: Any) -> None:

tests/test_config.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,3 +258,13 @@ def test_athena_wait_delay_config_override(wr: ModuleType, glue_database: str) -
258258
mock_wait_query.assert_called_once()
259259

260260
assert mock_wait_query.call_args[1]["athena_query_wait_polling_delay"] == polling_delay_argument
261+
262+
263+
@pytest.mark.parametrize("suppress_warnings", [False, True])
264+
def test_load_from_env_variable(wr: ModuleType, suppress_warnings: bool) -> None:
265+
env_variable_value = "1" if suppress_warnings else ""
266+
267+
with patch.dict(os.environ, {"WR_SUPPRESS_WARNINGS": env_variable_value}):
268+
wr.config.reset()
269+
270+
assert wr.config.suppress_warnings == suppress_warnings

0 commit comments

Comments
 (0)