Skip to content

chore: upgrade setuptools & pin cmake #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025
Merged

chore: upgrade setuptools & pin cmake #3152

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59e07ba
fix: update setuptools in layers
kukushking May 22, 2025
b7fadf5
use cmake<4
kukushking May 23, 2025
d0b7cdc
add comment
kukushking May 23, 2025
333b856
clarify comment
kukushking May 23, 2025
3416565
clarify comment
kukushking May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions building/lambda/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,14 @@ RUN ln -s /usr/bin/gcc10-ld /usr/bin/ld
FROM ${python_version}
COPY pyproject.toml poetry.lock ./

RUN pip3 install --upgrade pip wheel setuptools>=64 setuptools_scm>=8
# Setuptools is a build dependency of arrow and runtime dependency of some of our dependencies.
Copy link
Contributor Author

@kukushking kukushking May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

poetry show setuptools
 name         : setuptools                                                              
 version      : 80.8.0                                                                  
 description  : Easily download, build, install, upgrade, and uninstall Python packages 

required by
 - jupyterlab requires >=41.1.0
 - pbr requires *
 - redshift-connector requires *

# Remove when arrow version shipped with lambda layers is updated.
RUN pip3 install --upgrade pip wheel setuptools>=78.1.1 setuptools_scm>=8
RUN pip3 install --upgrade urllib3==1.26.16 # temporary to avoid https://github.com/urllib3/urllib3/issues/2168 (TODO remove when the AL2 image updates to support OpenSSL 1.1.1+)
RUN pip3 install --upgrade six cython cmake hypothesis poetry
# In new CMake 4, compatibility with CMake < 3.5 has been removed.
# Unpin CMake when arrow version shipped with lambda layers is updated.
RUN pip3 install --upgrade cmake==3.31.6
RUN pip3 install --upgrade six cython hypothesis poetry
ENV PIP_NO_BINARY="numpy,pandas"
RUN poetry config virtualenvs.create false --local && poetry install --no-root --only main

Expand Down
10 changes: 8 additions & 2 deletions building/lambda/Dockerfile.al2023
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,14 @@ WORKDIR /root
FROM ${python_version}
COPY pyproject.toml poetry.lock ./

RUN pip3 install --upgrade pip wheel setuptools>=64 setuptools_scm>=8
RUN pip3 install --upgrade six cython cmake hypothesis poetry
# Setuptools is a build dependency of arrow and runtime dependency of some of our dependencies.
# Remove when arrow version shipped with lambda layers is updated.
RUN pip3 install --upgrade pip wheel setuptools>=78.1.1 setuptools_scm>=8
# In new CMake 4, compatibility with CMake < 3.5 has been removed.
# Unpin CMake when arrow version shipped with lambda layers is updated.
RUN pip3 install --upgrade cmake==3.31.6
RUN pip3 install --upgrade six cython hypothesis poetry

ENV PIP_NO_BINARY="numpy,pandas"
RUN poetry config virtualenvs.create false --local && poetry install --no-root --only main

Expand Down