Fix require_https_for_sse_cpk option not being honored#3364
Open
monkeyWzr wants to merge 2 commits intoaws:version-3from
Open
Fix require_https_for_sse_cpk option not being honored#3364monkeyWzr wants to merge 2 commits intoaws:version-3from
monkeyWzr wants to merge 2 commits intoaws:version-3from
Conversation
The `require_https_for_sse_cpk` config option was documented as a way to disable the HTTPS enforcement for SSE-CPK operations, but the `require_https` handler method never checked it — the guard always raised regardless of the configured value. Gate the HTTPS check on `context.config.require_https_for_sse_cpk` so setting it to `false` actually allows HTTP endpoints (e.g. for local development against services like MinIO). Add specs covering the default enforcement behavior, the opt-out, and the key base64-encoding/MD5 logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2519 (not sure why it is closed).
The
require_https_for_sse_cpkconfig option was documented as a way to disable the HTTPS enforcement for SSE-CPK operations, but therequire_httpshandler method never checked it — the guard always raised regardless of the configured value.Gate the HTTPS check on
context.config.require_https_for_sse_cpkso setting it tofalseactually allows HTTP endpoints (e.g. for local development against services like MinIO).Changes:
SseCpkplugin to honorrequire_https_for_sse_cpkconfigBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.