generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 36
Add integration tests for cache behavior, version management, and cross-account access #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-account access
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 14 14
Lines 2418 2418
Branches 2418 2418
=======================================
Hits 2218 2218
Misses 150 150
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simonmarty
requested changes
Nov 3, 2025
simonmarty
previously approved these changes
Nov 4, 2025
simonmarty
reviewed
Nov 5, 2025
simonmarty
requested changes
Nov 5, 2025
lohdipak
reviewed
Nov 5, 2025
lohdipak
reviewed
Nov 5, 2025
lohdipak
reviewed
Nov 5, 2025
Signed-off-by: Simon Marty <martysi@amazon.com>
simonmarty
previously approved these changes
Nov 5, 2025
simonmarty
approved these changes
Nov 12, 2025
lohdipak
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds new integration tests that validate AWS Secrets Manager Agent behaviors requiring real AWS service interactions.
Changes Made
integration-tests/tests/common.rs- Refactoring for targeted setupsetup()with targeted setup methods:setup_basic()- Creates only Basic secretssetup_binary()- Creates only Binary secretssetup_versioned()- Creates only Versioned secretssetup_large()- Creates only Large secretscreated_typesfield to track which secrets were actually createdDropimplementation to only delete created secretssetup()method andALL_SECRET_TYPESconstantNow each test creates only what it needs.
integration-tests/tests/cache_behavior.rs- Test optimization and cleanupintegration-tests/tests/secret_retrieval.rs- Updated to use targeted setupintegration-tests/tests/version_management.rs- Updated to use targeted setupBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.