Decreasing default sleep time for refreshNow() calls, sleep time now … #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmarty
reviewed
Jun 16, 2025
src/main/java/com/amazonaws/secretsmanager/caching/SecretCacheConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/secretsmanager/caching/cache/SecretCacheObject.java
Show resolved
Hide resolved
simonmarty
approved these changes
Jun 16, 2025
ThirdEyeSqueegee
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #154
Description of changes: Decreased default sleep time for refreshNow() calls to be between 50 and 100 ms, also made this value configurable
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.