Skip to content

telemetry(amazonq): add languageServerVersion for some agentic chat metrics #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

telemetry(amazonq): add languageServerVersion for some agentic chat metrics #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,11 @@
"type": "int",
"description": "Number of code snippets in response"
},
{
"name": "cwsprChatResponseErrorReason",
Copy link
Contributor

@justinmk3 justinmk3 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you not using the existing fields reason or reasonDesc ?

Copy link
Contributor Author

@chungjac chungjac Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I haved used the reasonDesc field and not the cwsprChatResponseErrorReason field in this flare pr: aws/language-servers#1076

I was just uplifting the amazonq_messageResponseError metric and its corresponding types from vsc to common

"type": "string",
"description": "Client error reason when processing response stream"
},
{
"name": "cwsprChatResponseLength",
"type": "int",
Expand Down Expand Up @@ -2396,6 +2401,10 @@
{
"type": "cwsprChatWorkspaceContextTruncatedLength",
"required": false
},
{
"type": "languageServerVersion",
"required": false
}
]
},
Expand Down Expand Up @@ -2630,6 +2639,10 @@
},
{
"type": "cwsprChatConversationType"
},
{
"type": "languageServerVersion",
"required": false
}
]
},
Expand Down Expand Up @@ -2775,6 +2788,60 @@
}
]
},
{
"name": "amazonq_messageResponseError",
"description": "When an error has occured in response to a prompt",
"metadata": [
{
"type": "credentialStartUrl",
"required": false
},
{
"type": "cwsprChatActiveEditorImportCount",
"required": false
},
{
"type": "cwsprChatActiveEditorTotalCharacters",
"required": false
},
{
"type": "cwsprChatConversationId",
"required": false
},
{
"type": "cwsprChatConversationType"
},
{
"type": "cwsprChatHasCodeSnippet",
"required": false
},
{
"type": "cwsprChatProgrammingLanguage",
"required": false
},
{
"type": "cwsprChatRequestLength"
},
{
"type": "cwsprChatResponseCode"
},
{
"type": "cwsprChatResponseErrorReason",
"required": false
},
{
"type": "cwsprChatTriggerInteraction"
},
{
"type": "cwsprChatUserIntent",
"required": false
},
{
"type": "languageServerVersion",
"required": false
}
]
},
{
"name": "amazonq_modifySourceFolder",
"description": "User modified source folder",
Expand Down Expand Up @@ -2849,6 +2916,10 @@
},
{
"type": "cwsprToolUseId"
},
{
"type": "languageServerVersion",
"required": false
}
]
},
Expand Down