telemetry(amazonq): list of request ids in addMessage #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 13, 2025
justinmk3
reviewed
May 13, 2025
chungjac
force-pushed
the
request-ids
branch
5 times, most recently
from
ff3aa58 to
53b8ef3
Compare
jpinkney-aws
pushed a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
May 14, 2025
## Problem - Added new metrics in aws-toolkit-common package: aws/aws-toolkit-common#1024 ## Solution - Consume latest version of aws-toolkit-common package --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the new agentic chat after a user types a message, it may trigger multiple LLM calls, but we only store the final LLM requestID (
cwsprChatMessageId), which is the one that generates the response shown to the user. Earlier LLM calls in the sequence, which handle internal processing and aren't visible to users, are not currently emitted.We currently emit the LLM interaction events, but we lose emission of the associated LLM/Tool RequestID’s that led to the user interaction event (ie we don’t know which LLM requests the user click stop button, we don’t know which write tool ID the user chose to undo).
Solution
amazonq_addMessageamazonq_interactWithAgenticChatLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.