telemetry: add metrics for pinned context #1051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laileni-aws
reviewed
Jun 13, 2025
| @@ -1160,6 +1160,26 @@ | |||
| "type": "string", | |||
| "description": "Unique identifier for each message in an conversation" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Can we make these fields more generic like codeCount, fileCount etc to make it reusable?
There was a problem hiding this comment.
My understanding is that the metrics are specific to pinned context feature, we want to understand how the customers use this new feature.
What are purpose of the generic metrics codeCount, fileCount?
There was a problem hiding this comment.
The names of the types im adding use the same naming convention as the existing context count types:
except with the added prefix Pinned
this way we can keep track which context items were added in the prompt vs which were pinned
jngyuamz
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add telemetry for pinned context
New Metrics Added:
Pinned Context Counts
cwsprChatPinnedCodeContextCount: Tracks the number of pinned code symbols added to contextcwsprChatPinnedFileContextCount: Tracks the number of pinned files added to contextcwsprChatPinnedFolderContextCount: Tracks the number of pinned folders added to contextcwsprChatPinnedPromptContextCount: Tracks the number of pinned saved prompts added to contextRule Context Tracking
cwsprChatTotalRuleContextCount: Tracks the total number of workspace rules (both active and inactive)cwsprChatRuleContextCountto clarify it only includes active rulesAll new metrics have been added to
amazonq_addMessageand are marked as optional fields.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.