Skip to content

telemetry: add metrics for iam credentials authentication #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 23, 2025
Merged

telemetry: add metrics for iam credentials authentication #1070

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fed8776
add iamCredentialType and modify auth_userState and auth_addConnection
yuxianrz Jul 23, 2025
fa80cfb
add auth_iamOptionClick
yuxianrz Jul 23, 2025
5dc3f23
Reuse existing types
liramon1 Jul 23, 2025
9dfb004
Merge branch 'main' of github.com:yuxianrz/aws-toolkit-common
liramon1 Jul 23, 2025
682260b
fix metrics sorting
yuxianrz Jul 23, 2025
566d04c
modify for generic reason
yuxianrz Jul 23, 2025
fb84b4d
remove unneccessary required fiedl
yuxianrz Jul 23, 2025
70a3562
remove iam click and signin failure, add in credentialType for addCon…
yuxianrz Jul 23, 2025
5be76e0
add back signInOptionClick
yuxianrz Jul 23, 2025
0e320e0
remove unncessary signInClick
yuxianrz Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,6 +2133,16 @@
"type": "string",
"description": "The state of the setting being changed to. This should not be recorded for free-form settings like file-system paths. Instead, stick to things like flags, numbers, and enums."
},
{
"name": "signInOption",
"type": "string",
"allowedValues": [
"Company account",
"IAM Credentials",
"Other"
],
"description": "The sign in option for AmazonQ extension."
},
{
"name": "source",
"type": "string",
Expand Down Expand Up @@ -3988,6 +3998,27 @@
}
]
},
{
"name": "auth_loginFailure",
"description": "Emitted when User submit IAM/SSO form but receive error",
"metadata": [
{
"type": "credentialType"
},
{
"type": "reason"
}
]
},
{
"name": "auth_signInOptionClick",
"description": "Emitted when User click a login option from login webview",
"metadata": [
{
"type": "signInOption"
}
]
},
{
"name": "auth_signInPageClosed",
"description": "When the Amazon Q sign in page is closed.",
Expand Down