Skip to content

Add authType to loginWithBrowser metrics #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Add authType to loginWithBrowser metrics #877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d864a5
Add authType to loginWithBrowser metrics
manodnyab Oct 8, 2024
7783f0d
Update metric position to the correct alphabetical order
manodnyab Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,17 @@
],
"description": "Status of the an auth connection."
},
{
"name": "authType",
"type": "string",
"allowedValues": [
"PKCE",
Copy link
Contributor

@justinmk3 justinmk3 Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be AuthCode (or AuthCodePkce)?

"DeviceCode",
"IAM",
"Unknown"
],
"description": "The type of auth flow used for signing in"
},
{
"name": "awsAccount",
"type": "string",
Expand Down Expand Up @@ -2813,6 +2824,10 @@
"name": "aws_loginWithBrowser",
"description": "Extension navigated the user to a web browser to perform/complete the login process.",
"metadata": [
{
"type": "authType",
"required": false
},
{
"type": "credentialSourceId",
"required": false
Expand Down