telemetry: add definitions for code scan changes #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Oct 23, 2024
| "description": "The compressed payload size of built jars in bytes of customer project context sent for security scan. This is only applicable for Java project" | ||
| }, | ||
| { | ||
| "name": "codewhispererCodeScanInvocationSource", |
Contributor
There was a problem hiding this comment.
why not use the generic source field? it exists for this purpose.
aws-toolkit-common/telemetry/definitions/commonDefinitions.json
Lines 1649 to 1651 in b2a6280
justinmk3
reviewed
Oct 23, 2024
| }, | ||
| { | ||
| "name": "codewhisperer_codeScanIssueIgnore", | ||
| "description": "Called when a code scan issue is ignored", |
Contributor
There was a problem hiding this comment.
the description is a good place to explain non-obvious fields. e.g. could mention :
Suggested change
| "description": "Called when a code scan issue is ignored", | |
| "description": "User ignored a code scan issue. variant=all means the user ignored all issues. ", |
justinmk3
reviewed
Oct 23, 2024
| } | ||
| ] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
looks like your editor might be removing the final EOL. please check your editor/IDE settings
Contributor
Author
There was a problem hiding this comment.
Looks like it gets removed by running the validation script, but I can add it back manually
justinmk3
reviewed
Oct 23, 2024
| }, | ||
| { | ||
| "name": "codewhisperer_codeScanIssueGenerateFix", | ||
| "description": "Called when a code scan issue fix is generated", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Called when a code scan issue fix is generated", | |
| "description": "Generated a code scan issue. varant=... means ...", |
justinmk3
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continuation of #890
Solution
Add definitions for code scan changes
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.