Skip to content

telemetry: Code Scan Issue Fix diff usage #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2024
Merged

telemetry: Code Scan Issue Fix diff usage #907

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2c32a7d
Adding Telemetry event for Code Scan Issue Fix diff usage.
ashishrp-aws Nov 11, 2024
ba848b1
Fix for lint
ashishrp-aws Nov 11, 2024
1d0eb58
Fix for lint error
ashishrp-aws Nov 11, 2024
96a9272
Update telemetry/definitions/commonDefinitions.json
ashishrp-aws Nov 11, 2024
226c029
Corrections for Code issue fix diff event.
ashishrp-aws Nov 11, 2024
ca3a540
Fix for lint errors.
ashishrp-aws Nov 11, 2024
fa15296
Update telemetry/definitions/commonDefinitions.json
ashishrp-aws Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
{
"types": [
{
"name": "acceptedFixType",
"type": "string",
"description": "Captures the type of fix that was accepted",
"allowedValues": [
"acceptDiff",
"insertAtCursor",
"copyDiff"
Copy link
Contributor

@ctlai95 ctlai95 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this map to the buttons in the webview? If that's the case it should be openDiff instead of acceptDiff

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected it and added quickFix as well to codeFixActions

]
},
{
"name": "action",
"type": "string",
Expand Down Expand Up @@ -4398,6 +4408,34 @@
}
]
},
{
"name": "codewhisperer_codeScanIssueGenerateFixDiffUse",
Copy link
Contributor

@ctlai95 ctlai95 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add findingId?

Copy link
Contributor

@justinmk3 justinmk3 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already codewhisperer_codeScanIssueApplyFix . why can't "diff" be a field (name TBD) on that existing metric?

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the codeFixAction to codewhisperer_codeScanIssueApplyFix

"description": "User chose to utilise the diff of a code scan issue fix",
"metadata": [
{
"type": "acceptedFixType",
"required": false
},
{
"type": "component"
},
{
"type": "credentialStartUrl",
"required": false
},
{
"type": "detectorId"
},
{
"type": "ruleId",
"required": false
},
{
"type": "variant",
Copy link
Contributor

@ctlai95 ctlai95 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will variant be used here?

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore.

"required": false
}
]
},
{
"name": "codewhisperer_codeScanIssueHover",
"description": "Called when a code scan issue is hovered over",
Expand Down