Skip to content

feat: add general latency metrics #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

feat: add general latency metrics #913

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dadda6d
feat: add general latency metrics
jpinkney-aws Nov 13, 2024
2c29058
fixup
jpinkney-aws Nov 13, 2024
760dd9d
change to perf prefix
jpinkney-aws Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@
],
"description": "User inputted check type to denote which custom check to run."
},
{
"name": "clientLatency",
Copy link
Contributor

@justinmk3 justinmk3 Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since teams have indicated that it's hard to find related metrics, should we deviate a bit from our normal pattern and use latency as a prefix for all of this? Or maybe even perf as a prefix would help group all perf-related fields in the future.

Copy link
Contributor Author

@jpinkney-aws jpinkney-aws Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things like latency and duration are already naturally searchable. What advantages would we get if we prefixed with latency or perf? My problem with telemetry right now is every time I search for something that could be general it starts with the prefix of a team/project name 😅

Copy link
Contributor

@justinmk3 justinmk3 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they will be grouped together

"type": "double",
"description": "The time duration in milliseconds to process an action on the client side"
},
{
"name": "cloudWatchLogsPresentation",
"type": "string",
Expand Down Expand Up @@ -1138,14 +1143,19 @@
],
"description": "The type of DynamoDB entity referenced by a metric or operation"
},
{
"name": "e2eLatency",
"type": "double",
"description": "The time duration in milliseconds to complete an end to end flow"
},
{
"name": "ec2ConnectionType",
"type": "string",
"allowedValues": [
"remoteDesktop",
"ssh",
"scp",
"ssm",
"ssm",
"remoteWorkspace"
],
"description": "Ways to connect to an EC2 Instance"
Expand Down Expand Up @@ -1627,6 +1637,11 @@
],
"description": "Languages targeted by the schemas service"
},
{
"name": "serverLatency",
"type": "double",
"description": "The time duration in milliseconds to finish a request to the server side"
},
{
"name": "serviceType",
"type": "string",
Expand Down Expand Up @@ -7065,4 +7080,4 @@
]
}
]
}
}